[jira] [Commented] (KAFKA-3029) Make class org.apache.kafka.common.TopicPartition Serializable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068363#comment-15068363 ] 

ASF GitHub Bot commented on KAFKA-3029:
---------------------------------------

GitHub user praveend opened a pull request:

    https://github.com/apache/kafka/pull/711

    KAFKA-3029:Marking class org.apache.kafka.common.TopicPartition as serializable

    Patch for issue KAFKA-3029
    
    Given that the fix is trivial no new test case is needed. I have run the test suite using gradle (as mentioned @ https://github.com/apache/kafka/blob/trunk/README.md) and suite runs clean.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/praveend/kafka tp_serializable_branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #711
    
----
commit 66bda1b1d9e1e073efcd1c9caa166e6817874a47
Author: Praveen Devarao <pr...@in.ibm.com>
Date:   2015-12-22T15:28:10Z

    Marking class org.apache.kafka.common.TopicPartition as serializable

----


> Make class org.apache.kafka.common.TopicPartition Serializable
> --------------------------------------------------------------
>
>                 Key: KAFKA-3029
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3029
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 0.9.0.0
>            Reporter: Praveen Devarao
>              Labels: easyfix, patch
>             Fix For: 0.9.0.1
>
>
> The client class TopicPartition is exposed and used by consumer applications directly. In case where the application needs to checkpoint the state it is difficult to serialize different app classes that use TopicPartition as TopicParitition is not serializable.
> For instance consider the Spark use case where RDDs have to be checkpointed....the KafakaInputDstream (which we are currently modifying to use the new Kafka API rather than the Highlevel apis in previous version) cannot be serialized due to above limitation.
> I have created a patch to serialize TopicPartition class by making it implement serializable interface and have issued a pull request.
> Can this be merged for the next release (0.9.0.1)
> Thanks
> Praveen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)