You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2014/02/18 14:28:48 UTC

[Bug 56152] New: ProxyBlock does not accept network addresses

https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

            Bug ID: 56152
           Summary: ProxyBlock does not accept network addresses
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_proxy
          Assignee: bugs@httpd.apache.org
          Reporter: lkundrak@v3.sk

You can not easily block address ranges such as "ProxyBlock 127.0.0.0/8".

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

Lubomir Rintel <lk...@v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31319|0                           |1
        is obsolete|                            |

--- Comment #3 from Lubomir Rintel <lk...@v3.sk> ---
Created attachment 31321
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31321&action=edit
[PATCH 1/4] mod_proxy: Rename dirconn_entry to exclude_entry

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

--- Comment #5 from Lubomir Rintel <lk...@v3.sk> ---
Created attachment 31323
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31323&action=edit
[PATCH 3/4] mod_proxy: Split the NoProxy parameter parsing away

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

Lubomir Rintel <lk...@v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

Lubomir Rintel <lk...@v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

--- Comment #7 from Lubomir Rintel <lk...@v3.sk> ---
The patch set reuses code that's already used for the NoProxy directive.

Diffstat:

 docs/manual/mod/mod_proxy.xml | 14 ++--
 modules/proxy/mod_proxy.c     | 83 ++++++++++-------------
 modules/proxy/mod_proxy.h     |  9 +--
 modules/proxy/proxy_util.c    | 67 ++++++------------
 modules/proxy/proxy_util.h    |  8 +--
 5 files changed, 69 insertions(+), 112 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

--- Comment #9 from Lubomir Rintel <lk...@v3.sk> ---
I'm really not sure. I've did my best to avoid unnecessary complexity (there's
more removals than additions in the end). I've tried not to mix unrelated
changes and tried keep logical chunks in separate patches with appropriate
explanations.

I could definitely try to improve things you find needlessly complex or
unclear, but I'd need more specific input for that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

Jim Jagielski <ji...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #8 from Jim Jagielski <ji...@apache.org> ---
Glancing over the patches, they look more complex than needed... can it be simp
lyfied and combined?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

--- Comment #6 from Lubomir Rintel <lk...@v3.sk> ---
Created attachment 31324
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31324&action=edit
[PATCH 4/4] mod_proxy: Share NoProxy parameter parsing and evaluation

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

--- Comment #2 from Lubomir Rintel <lk...@v3.sk> ---
Created attachment 31320
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31320&action=edit
[PATCH 2/4] mod_proxy: Split the NoProxy parameter parsing away

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

--- Comment #1 from Lubomir Rintel <lk...@v3.sk> ---
Created attachment 31319
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31319&action=edit
[PATCH 1/4] mod_proxy: Match resolved addresses for NoProxy too

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 56152] ProxyBlock does not accept network addresses

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56152

Lubomir Rintel <lk...@v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31320|0                           |1
        is obsolete|                            |

--- Comment #4 from Lubomir Rintel <lk...@v3.sk> ---
Created attachment 31322
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31322&action=edit
[PATCH 2/4] mod_proxy: Match resolved addresses for NoProxy too

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org