[GitHub] [spark] attilapiros commented on a change in pull request #23767: [SPARK-26329][CORE] Faster polling of executor memory metrics.

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #23767: [SPARK-26329][CORE] Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r288513645
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
 ##########
 @@ -412,6 +432,11 @@ private[spark] class Executor(
           env.mapOutputTracker.asInstanceOf[MapOutputTrackerWorker].updateEpoch(task.epoch)
         }
 
+        val stageId = task.stageId
+        val stageAttemptId = task.stageAttemptId
+        metricsPoller.onTaskStart(taskId, stageId, stageAttemptId)
+        taskStarted = true
 
 Review comment:
   I cannot see why this boolean is needed. If it is really needed then please add a short comment explaining the reason behind.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org