You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/08/25 20:11:59 UTC
[jira] Created: (WINK-151) Make deployment configuration public
Make deployment configuration public
------------------------------------
Key: WINK-151
URL: https://issues.apache.org/jira/browse/WINK-151
Project: Wink
Issue Type: Improvement
Components: Server
Affects Versions: 0.2
Reporter: Bryant Luk
Fix For: 0.2
Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-151) Make deployment configuration public
Posted by "Nick Gallardo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748386#action_12748386 ]
Nick Gallardo commented on WINK-151:
------------------------------------
The patch looks good to me, but I agree with you on the name. I instantly thought @Provider as well. How about... HandlerFactory? Or, HandlerConfigurator?
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-151) Make deployment configuration public
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747838#action_12747838 ]
Hudson commented on WINK-151:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #118 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/118/])
Make RuntimeContext public. See []
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-151) Make deployment configuration public
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman updated WINK-151:
-------------------------------
Attachment: WINK-151.patch
Here comes the proposed solution.
The idea is that user should extend from HandlersProvider and specify the impl class name in the properties file (see unit test).
I'm not too happy with the name HandlersProvider, since it may be mistaken with the "provider" term, so I'm open to suggestions.
Finally, I don't think we need to make DeploymentConfiguration public, but we should rather remove it from the documentation and leave it internal.
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WINK-151) Make deployment configuration public
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman reassigned WINK-151:
----------------------------------
Assignee: Michael Elman
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-151) Make deployment configuration public
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-151.
---------------------------
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151-2.patch, WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-151) Make deployment configuration public
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747799#action_12747799 ]
Michael Elman commented on WINK-151:
------------------------------------
Moving RuntimeContext to org.apache.wink.common. In general users should not use this class directly, so it was initially put to internal. However, since MessageContext extends it, putting it under internal causes developers to think it may be changed, while it should still keep the backward compatibility.
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-151) Make deployment configuration public
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-151:
----------------------------
Attachment: WINK-151-2.patch
Here's my slightly modified proposal.
I think since it is documented in the 0.1 release with all the PDF/word files that we should maintain compatibility with the older class and keep the init* methods for now. I do understand that we want to keep internal APIs private but for migration purposes this doesn't cost us anything and we can have a deprecation/warning.
I also believe this fixes a minor issue with the case where the boolean VALIDATE_LOCATION_HEADER and the associated handler wasn't being checked if there wasn't a handlerproviders class called. I also correct a slight typo in the unit test. Dunno if that was intentional or not.
I'm even more terrible with names so I'll defer to Nick's suggestions...
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151-2.patch, WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-151) Make deployment configuration public
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman resolved WINK-151.
--------------------------------
Resolution: Fixed
I've applied the patch with Bryant and Nick suggestions.
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151-2.patch, WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-151) Make deployment configuration public
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749232#action_12749232 ]
Hudson commented on WINK-151:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #122 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/122/])
Add API for handlers configuration.
See []
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151-2.patch, WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.