You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:58:14 UTC

[GitHub] [thrift] dcelasun commented on pull request #2469: THRIFT-5423: Support go parameter validation in IDL

dcelasun commented on PR #2469:
URL: https://github.com/apache/thrift/pull/2469#issuecomment-1212887270

   The code is generally OK, minor issues aside. 
   
   > We are adding a new `VALIDATION_FAILED` to `TApplicationException`
   
   This should be fine, I can't think of a realistic scenario where it'd be a problem.
   
   More generally, I'm not sure about "tool functions". It can easily cause further drift between supported languages. I think we should define and document which functions we support (`len()` is fine). We can add more in future versions if necessary.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org