You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/05 12:30:43 UTC

[jira] Created: (HARMONY-309) linux.IA32/port/hysock.c end of non-void function has no return

linux.IA32/port/hysock.c end of non-void function has no return
---------------------------------------------------------------

         Key: HARMONY-309
         URL: http://issues.apache.org/jira/browse/HARMONY-309
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Trivial
 Attachments: linux.port.hysock.missing.return.diff

Control can reach the end of this function:

  I_32 VMCALL hysock_connect_with_timeout ( ... );

and the return statement is missing.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-309) linux.IA32/port/hysock.c end of non-void function has no return

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-309?page=comments#action_12373474 ] 

Mark Hindess commented on HARMONY-309:
--------------------------------------

Looks good.  Your fix makes more sense.  Thanks Tim.

> linux.IA32/port/hysock.c end of non-void function has no return
> ---------------------------------------------------------------
>
>          Key: HARMONY-309
>          URL: http://issues.apache.org/jira/browse/HARMONY-309
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: linux.port.hysock.missing.return.diff
>
> Control can reach the end of this function:
>   I_32 VMCALL hysock_connect_with_timeout ( ... );
> and the return statement is missing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-309) linux.IA32/port/hysock.c end of non-void function has no return

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-309?page=all ]

Tim Ellison reassigned HARMONY-309:
-----------------------------------

    Assign To: Tim Ellison

> linux.IA32/port/hysock.c end of non-void function has no return
> ---------------------------------------------------------------
>
>          Key: HARMONY-309
>          URL: http://issues.apache.org/jira/browse/HARMONY-309
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: linux.port.hysock.missing.return.diff
>
> Control can reach the end of this function:
>   I_32 VMCALL hysock_connect_with_timeout ( ... );
> and the return statement is missing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-309) linux.IA32/port/hysock.c end of non-void function has no return

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-309?page=all ]
     
Tim Ellison closed HARMONY-309:
-------------------------------


Verified by Mark


> linux.IA32/port/hysock.c end of non-void function has no return
> ---------------------------------------------------------------
>
>          Key: HARMONY-309
>          URL: http://issues.apache.org/jira/browse/HARMONY-309
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: linux.port.hysock.missing.return.diff
>
> Control can reach the end of this function:
>   I_32 VMCALL hysock_connect_with_timeout ( ... );
> and the return statement is missing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-309) linux.IA32/port/hysock.c end of non-void function has no return

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-309?page=all ]
     
Tim Ellison resolved HARMONY-309:
---------------------------------

    Resolution: Fixed

Thanks Mark,

I didn't use your patch but fixed the problem in a different way in
  win.IA32/port/hysock.c
  linux.IA32/port/hysock.c
at repo revision 391817.

Please check that this fully resolves your problem.


> linux.IA32/port/hysock.c end of non-void function has no return
> ---------------------------------------------------------------
>
>          Key: HARMONY-309
>          URL: http://issues.apache.org/jira/browse/HARMONY-309
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Tim Ellison
>     Priority: Trivial
>  Attachments: linux.port.hysock.missing.return.diff
>
> Control can reach the end of this function:
>   I_32 VMCALL hysock_connect_with_timeout ( ... );
> and the return statement is missing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-309) linux.IA32/port/hysock.c end of non-void function has no return

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-309?page=all ]

Mark Hindess updated HARMONY-309:
---------------------------------

    Attachment: linux.port.hysock.missing.return.diff

Patch to add the missing return statement.


> linux.IA32/port/hysock.c end of non-void function has no return
> ---------------------------------------------------------------
>
>          Key: HARMONY-309
>          URL: http://issues.apache.org/jira/browse/HARMONY-309
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Trivial
>  Attachments: linux.port.hysock.missing.return.diff
>
> Control can reach the end of this function:
>   I_32 VMCALL hysock_connect_with_timeout ( ... );
> and the return statement is missing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira