You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2023/10/24 13:05:36 UTC

[PR] Ignore all individual acknowledge for CompactorSubscription [pulsar]

coderzc opened a new pull request, #21434:
URL: https://github.com/apache/pulsar/pull/21434

   ### Motivation
   
   For CompactorSubscription, we should ignore all individual acknowledges instead of throwing exceptions.
   
   ### Modifications
   
   Remove `individualAcknowledgeMessageIfNeeded` method and ignore all individual acknowledge in CompactorSubscription.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker] Ignore individual acknowledgment for CompactorSubscription when an entry has been filtered. [pulsar]

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc merged PR #21434:
URL: https://github.com/apache/pulsar/pull/21434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker] Ignore individual acknowledgment for CompactorSubscription when an entry has been filtered. [pulsar]

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on PR #21434:
URL: https://github.com/apache/pulsar/pull/21434#issuecomment-1778491321

   > Please add a test to verify this change
   
   I have added a test for this change, please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker] Ignore individual acknowledgment for CompactorSubscription when an entry has been filtered. [pulsar]

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc closed pull request #21434: [fix][broker] Ignore individual acknowledgment for CompactorSubscription when an entry has been filtered.
URL: https://github.com/apache/pulsar/pull/21434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org