You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/19 23:51:30 UTC
[GitHub] [airflow] mik-laj opened a new pull request #8463: Clearer error messages when the configuration is incorrect
mik-laj opened a new pull request #8463:
URL: https://github.com/apache/airflow/pull/8463
When we import objects specified in the configuration file, the operation may fail. We should say which configuration option the user should check.
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #8463: User-friendly error messages when the configuration is incorrect
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8463:
URL: https://github.com/apache/airflow/pull/8463#issuecomment-619659464
@potiuk Can I ask for review again? I updated more options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #8463: Clearer error messages when the configuration is incorrect
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #8463:
URL: https://github.com/apache/airflow/pull/8463#discussion_r411020602
##########
File path: airflow/configuration.py
##########
@@ -304,6 +305,27 @@ def getint(self, section, key, **kwargs):
def getfloat(self, section, key, **kwargs):
return float(self.get(section, key, **kwargs))
+ def getimport(self, section, key, **kwargs):
+ """
+ Reads options, imports the full qualified name, and returns the object.
+
+ In case of failure, it throws an exception a clear message with the key aad the section names
Review comment:
```suggestion
In case of failure, it throws an exception a clear message with the key and the section names
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org