You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/04 13:56:32 UTC
[GitHub] [spark] MaxGekk commented on a change in pull request #27753:
[SPARK-31005][SQL] Support time zone ids in casting strings to timestamps
MaxGekk commented on a change in pull request #27753: [SPARK-31005][SQL] Support time zone ids in casting strings to timestamps
URL: https://github.com/apache/spark/pull/27753#discussion_r387681063
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -170,28 +170,28 @@ object DateTimeUtils {
* `yyyy-[m]m`
* `yyyy-[m]m-[d]d`
* `yyyy-[m]m-[d]d `
- * `yyyy-[m]m-[d]d [h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]`
- * `yyyy-[m]m-[d]d [h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]Z`
- * `yyyy-[m]m-[d]d [h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]-[h]h:[m]m`
- * `yyyy-[m]m-[d]d [h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]+[h]h:[m]m`
- * `yyyy-[m]m-[d]dT[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]`
- * `yyyy-[m]m-[d]dT[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]Z`
- * `yyyy-[m]m-[d]dT[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]-[h]h:[m]m`
- * `yyyy-[m]m-[d]dT[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]+[h]h:[m]m`
- * `[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]`
- * `[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]Z`
- * `[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]-[h]h:[m]m`
- * `[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]+[h]h:[m]m`
- * `T[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]`
- * `T[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]Z`
- * `T[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]-[h]h:[m]m`
- * `T[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]+[h]h:[m]m`
+ * `yyyy-[m]m-[d]d [h]h:[m]m:[s]s.[ms][ms][ms][us][us][us][zone_id]`
+ * `yyyy-[m]m-[d]dT[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us][zone_id]`
+ * `[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us][zone_id]`
+ * `T[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us][zone_id]`
+ *
+ * where `zone_id` should have one of the forms:
+ * - Z - Zulu time zone UTC+0
+ * - +|-[h]h:[m]m
Review comment:
It is required:
```scala
scala> stringToTimestamp(UTF8String.fromString("2020-03-04 10:11:12.00000010:00"), ZoneOffset.UTC)
res2: Option[org.apache.spark.sql.catalyst.util.DateTimeUtils.SQLTimestamp] = None
scala> stringToTimestamp(UTF8String.fromString("2020-03-04 10:11:12.000000+10:00"), ZoneOffset.UTC)
res3: Option[org.apache.spark.sql.catalyst.util.DateTimeUtils.SQLTimestamp] = Some(1583280672000000)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org