You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/18 14:43:18 UTC

[GitHub] [pulsar] Renkai opened a new pull request #9616: Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

Renkai opened a new pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616


   Use `ManagedLedger` instead of `ManagedLedgerImpl` in `ManagedLedgerFactoryImpl` to make the `ManagedLedgerFactoryImpl` extendable.
   As a result, some method declarations also moved from `ManagedLedgerImpl` to `ManagedLedger`. 
   Next step of https://github.com/apache/pulsar/pull/9397 to allow supporting different storage implementations for Pulsar


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai commented on a change in pull request #9616: Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

Posted by GitBox <gi...@apache.org>.
Renkai commented on a change in pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616#discussion_r578506072



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java
##########
@@ -102,7 +102,15 @@ public void initialize(ServiceConfiguration conf, ZooKeeper zkClient,
         };
 
         this.managedLedgerFactory =
-                new ManagedLedgerFactoryImpl(bkFactory, zkClient, managedLedgerFactoryConfig, statsLogger);
+                createManagedLedgerFactory(zkClient, managedLedgerFactoryConfig, statsLogger, bkFactory);
+    }
+
+    protected ManagedLedgerFactoryImpl
+    createManagedLedgerFactory(ZooKeeper zkClient,

Review comment:
       My IDE deal with the indent for me, I'm not sure what's the meaning of your 'fix indent' here. But I think the reason why the indent looks a little weird is that `BookkeeperFactoryForCustomEnsemblePlacementPolicy` is too long, the IDE has to format like this to make a line less than 120 chars.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai commented on pull request #9616: Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616#issuecomment-781736555


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai commented on pull request #9616: Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616#issuecomment-781421822


   @sijie PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on a change in pull request #9616: Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616#discussion_r578497231



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java
##########
@@ -102,7 +102,15 @@ public void initialize(ServiceConfiguration conf, ZooKeeper zkClient,
         };
 
         this.managedLedgerFactory =
-                new ManagedLedgerFactoryImpl(bkFactory, zkClient, managedLedgerFactoryConfig, statsLogger);
+                createManagedLedgerFactory(zkClient, managedLedgerFactoryConfig, statsLogger, bkFactory);
+    }
+
+    protected ManagedLedgerFactoryImpl
+    createManagedLedgerFactory(ZooKeeper zkClient,

Review comment:
       nit: fix indent




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai closed pull request #9616: [WIP]Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

Posted by GitBox <gi...@apache.org>.
Renkai closed pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org