[GitHub] [arrow-rs] alamb commented on a diff in pull request #2094: Pass generate_decimal256_case integration test

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2094:
URL: https://github.com/apache/arrow-rs/pull/2094#discussion_r926013472


##########
arrow/src/datatypes/datatype.rs:
##########
@@ -195,6 +195,8 @@ pub enum DataType {
     ///
     /// For example the number 123.45 has precision 5 and scale 2.
     Decimal(usize, usize),
+    /// Exact decimal value with 256 bits width
+    Decimal256(usize, usize),

Review Comment:
   Should we also rename `Decimal` to `Decimal128`? 
   
   Or maybe use an extra mode in Decimal like `
   
   ```rust
   enum BitWidth {
     // 128 bits
     Bits128,
     // 256 bits
     Bits256,
   }
   
   
   enum DataType {
   ..
     Decimal(usize, usize, DecimalWidth)
   }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org