You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/01 20:45:21 UTC

[GitHub] [beam] aaltay commented on a change in pull request #11279: [BEAM-9653] remove _AvroSource in favor of using _FastAvroSource

aaltay commented on a change in pull request #11279: [BEAM-9653] remove _AvroSource in favor of using _FastAvroSource
URL: https://github.com/apache/beam/pull/11279#discussion_r401898368
 
 

 ##########
 File path: sdks/python/apache_beam/io/avroio.py
 ##########
 @@ -451,7 +404,6 @@ class _FastAvroSource(filebasedsource.FileBasedSource):
   common to all file-based sources such as file-pattern expansion and splitting
   into bundles for parallel processing.
 
-  TODO: remove ``_AvroSource`` in favor of using ``_FastAvroSource``
   everywhere once it has been more widely tested
 
 Review comment:
   I believe most of the users are still on the regular avro. If I remember correctly, for python3 the default is fastavro, for python2 the default is avro with a flag to change it.
   
   @chamikaramj - what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services