You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2026/09/18 00:54:23 UTC
[PR] Fix flaky ReceivingMailboxTest.readingUnblocksWriters [pinot]
Jackie-Jiang opened a new pull request, #19597:
URL: https://github.com/apache/pinot/pull/19597
## Summary
`ReceivingMailboxTest.readingUnblocksWriters` fails intermittently on `assertTrue(blocked.isDone())`:
```
java.lang.AssertionError: The blocked offer should be unblocked by reading expected [true] but found [false]
at org.apache.pinot.query.mailbox.ReceivingMailboxTest.readingUnblocksWriters(ReceivingMailboxTest.java:326)
```
The test fills a capacity-2 mailbox, submits a third offer that blocks, then polls until it has read three blocks. Once the first poll frees a slot, the writer thread enqueues the third block under the queue lock, releases the lock, and only afterwards returns from `offer()`, at which point the `CompletableFuture` wrapping it completes. The main thread can poll that third block as soon as the lock is released, so it reaches the `isDone()` check while the writer is still returning. The assertion is therefore racy by construction.
The next line, `assertEquals(blocked.get(), SUCCESS, ...)`, already waits for the offer to finish and verifies that reading unblocked it, and the method's `timeOut` covers a hang. This removes the `isDone()` assertion.
Example failure: https://github.com/apache/pinot/actions/runs/35273748527/job/105379174130
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix flaky ReceivingMailboxTest.readingUnblocksWriters [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19597:
URL: https://github.com/apache/pinot/pull/19597#issuecomment-5723653180
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19597?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 39.54%. Comparing base ([`5b650ae`](https://app.codecov.io/gh/apache/pinot/commit/5b650aed3bc7a316476cf273175e0ea620ea71b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5b105e`](https://app.codecov.io/gh/apache/pinot/commit/c5b105ea594a0e09f58fc8dab23cd16f88795024?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (5b650ae) and HEAD (c5b105e). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (5b650ae) | HEAD (c5b105e) |
>|------|------|------|
>|lane-a|2|0|
>|integration|4|0|
>|java-25|6|1|
>|integration2|2|0|
>|temurin|6|1|
>|lane-b|2|0|
>|unittests1|1|0|
>|unittests|2|1|
>|integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19597 +/- ##
=============================================
- Coverage 67.83% 39.54% -28.29%
+ Complexity 1450 1443 -7
=============================================
Files 3504 3504
Lines 226575 226575
Branches 35803 35803
=============================================
- Hits 153695 89602 -64093
- Misses 60752 128861 +68109
+ Partials 12128 8112 -4016
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.54% <ø> (-28.29%)` | :arrow_down: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.54% <ø> (-28.29%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.54% <ø> (-28.29%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.54% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19597?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix flaky ReceivingMailboxTest.readingUnblocksWriters [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #19597:
URL: https://github.com/apache/pinot/pull/19597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org