You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jg...@apache.org on 2018/11/13 17:43:41 UTC
[kafka] branch trunk updated: MINOR: Remove unused abstract
function in test class (#5888)
This is an automated email from the ASF dual-hosted git repository.
jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new f52de5f MINOR: Remove unused abstract function in test class (#5888)
f52de5f is described below
commit f52de5f0adf1d3d3557aa38421d9212a1f768b19
Author: Cyrus Vafadari <cy...@alum.mit.edu>
AuthorDate: Tue Nov 13 09:43:29 2018 -0800
MINOR: Remove unused abstract function in test class (#5888)
The function `setup_producer_and_consumer` is unused in the system test
framework, which incorrectly suggests subclasses should implement
it. It is not required or even referenced by the framework, so
the requirement should be removed.
Reviewers: Viktor Somogyi <vi...@gmail.com>, Jason Gustafson <ja...@confluent.io>
---
tests/kafkatest/tests/produce_consume_validate.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/kafkatest/tests/produce_consume_validate.py b/tests/kafkatest/tests/produce_consume_validate.py
index 7a78da3..6979b94 100644
--- a/tests/kafkatest/tests/produce_consume_validate.py
+++ b/tests/kafkatest/tests/produce_consume_validate.py
@@ -44,9 +44,6 @@ class ProduceConsumeValidateTest(Test):
self.consumer_init_timeout_sec = 0
self.enable_idempotence = False
- def setup_producer_and_consumer(self):
- raise NotImplementedError("Subclasses should implement this")
-
def start_producer_and_consumer(self):
# Start background producer and consumer
self.consumer.start()