You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/16 00:41:39 UTC

[GitHub] [commons-lang] XenoAmess commented on pull request #428: [LANG-1546] change to

XenoAmess commented on pull request #428:
URL: https://github.com/apache/commons-lang/pull/428#issuecomment-644463141


   > Hi @XenoAmess , haven't looked at this PR in a while. But I **think** it was doing as the title says before, i.e. it was changing from `<docEncoding>` to `<docencoding>`.
   > 
   > But I had a look at the changes, and looks like it's now removing that. Could you explain the rationale for that? Is it to retrieve the value from the parent? Sorry, I missed the context, so if you could explain this I will take another look and see if it can be merged soon-ish 👍
   
   see content in `michael-o requested changes on Jun 3, 2019`
   that is resolved so hided.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org