You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/05 14:37:02 UTC
[GitHub] [camel-quarkus] galderz opened a new pull request #1185: Add jaxb as dependency and allow skipping formatting
galderz opened a new pull request #1185:
URL: https://github.com/apache/camel-quarkus/pull/1185
Fixes extra commits issues in https://github.com/apache/camel-quarkus/pull/1163, and added a commit to allow formatting checks to be skipped altogether (present in quarkus).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1185: Add jaxb as dependency and allow skipping formatting
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1185:
URL: https://github.com/apache/camel-quarkus/pull/1185#discussion_r420217028
##########
File path: extensions-core/core/deployment/pom.xml
##########
@@ -49,6 +49,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-arc-deployment</artifactId>
</dependency>
+ <dependency>
Review comment:
```suggestion
<dependency><!-- temporary fix for #1161, remove with Camel 3.3 -->
```
##########
File path: extensions-core/core/runtime/pom.xml
##########
@@ -56,6 +56,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-arc</artifactId>
</dependency>
+ <dependency>
Review comment:
```suggestion
<dependency><!-- temporary fix for #1161, remove with Camel 3.3 -->
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] galderz commented on pull request #1185: Add jaxb as dependency and allow skipping formatting
Posted by GitBox <gi...@apache.org>.
galderz commented on pull request #1185:
URL: https://github.com/apache/camel-quarkus/pull/1185#issuecomment-624513244
@ppalaga Fixed comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] galderz commented on pull request #1185: Add jaxb as dependency and allow skipping formatting
Posted by GitBox <gi...@apache.org>.
galderz commented on pull request #1185:
URL: https://github.com/apache/camel-quarkus/pull/1185#issuecomment-626496746
Thx @ppalaga. Anything else missing here? Or can it be integrated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] galderz commented on pull request #1185: Add jaxb as dependency and allow skipping formatting
Posted by GitBox <gi...@apache.org>.
galderz commented on pull request #1185:
URL: https://github.com/apache/camel-quarkus/pull/1185#issuecomment-624499476
@ppalaga I'll fix those.
I've verified that format skipping works as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org