You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/25 22:29:42 UTC
[GitHub] [tvm] electriclilies opened a new pull request #7532: [BUG_FIX][TOPI] Allow topi resize to accept more options
electriclilies opened a new pull request #7532:
URL: https://github.com/apache/tvm/pull/7532
In PR #6298, we restricted the options supported by topi resize. This was incorrect and was causing failures in the onnx importer tests for resize. This PR removes the check added in #6289, and adds more tests to topi and onnx.
Finally, the topi testing suite can't produce reference values for resize with the options nearest_neighbor and align_corners, so I skip that combo in the topi and relay op tests. However, these options work in the onnx tests, so it's not a huge concern.
@mbrookhart Please take a look!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #7532: [BUG_FIX][TOPI] Allow topi resize to accept more options
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #7532:
URL: https://github.com/apache/tvm/pull/7532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies commented on a change in pull request #7532: [BUG_FIX][TOPI] Allow topi resize to accept more options
Posted by GitBox <gi...@apache.org>.
electriclilies commented on a change in pull request #7532:
URL: https://github.com/apache/tvm/pull/7532#discussion_r583398361
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -3356,15 +3356,19 @@ def verify(ishape, oshape, scales, mode, coord_trans):
# upsampling
verify([1, 16, 32, 32], [1, 16, 64, 64], [], "nearest", "asymmetric")
+ verify([1, 16, 32, 32], [1, 16, 64, 64], [], "linear", "asymmetric")
+ verify([1, 16, 32, 32], [1, 16, 64, 64], [], "nearest", "align_corners")
verify([1, 16, 32, 32], [1, 16, 64, 64], [], "linear", "align_corners")
+ verify([1, 16, 32, 32], [1, 16, 64, 64], [], "nearest", "half_pixel")
verify([1, 16, 32, 32], [1, 16, 64, 64], [], "linear", "half_pixel")
- # downsampling
Review comment:
Whoops, I thought they were the same as the upsampling tests (I can read).. I'll add them back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on a change in pull request #7532: [BUG_FIX][TOPI] Allow topi resize to accept more options
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on a change in pull request #7532:
URL: https://github.com/apache/tvm/pull/7532#discussion_r583261352
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -3356,15 +3356,19 @@ def verify(ishape, oshape, scales, mode, coord_trans):
# upsampling
verify([1, 16, 32, 32], [1, 16, 64, 64], [], "nearest", "asymmetric")
+ verify([1, 16, 32, 32], [1, 16, 64, 64], [], "linear", "asymmetric")
+ verify([1, 16, 32, 32], [1, 16, 64, 64], [], "nearest", "align_corners")
verify([1, 16, 32, 32], [1, 16, 64, 64], [], "linear", "align_corners")
+ verify([1, 16, 32, 32], [1, 16, 64, 64], [], "nearest", "half_pixel")
verify([1, 16, 32, 32], [1, 16, 64, 64], [], "linear", "half_pixel")
- # downsampling
Review comment:
Why remove down-sampling tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies commented on pull request #7532: [BUG_FIX][TOPI] Allow topi resize to accept more options
Posted by GitBox <gi...@apache.org>.
electriclilies commented on pull request #7532:
URL: https://github.com/apache/tvm/pull/7532#issuecomment-786937527
Thanks @mbrookhart :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7532: [BUG_FIX][TOPI] Allow topi resize to accept more options
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7532:
URL: https://github.com/apache/tvm/pull/7532#issuecomment-786891723
Thanks @electriclilies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org