You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/11 04:29:51 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #14858: [fix][pulsar-admin] Fix pulsar-admin could create partitioned topic even namespace does not exist via V1 path

Technoboy- commented on code in PR #14858:
URL: https://github.com/apache/pulsar/pull/14858#discussion_r869859321


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -577,11 +577,9 @@ protected void internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
             Policies policies = getNamespacePolicies(namespaceName);
             maxTopicsPerNamespace = policies.max_topics_per_namespace;
         } catch (RestException e) {
-            if (e.getResponse().getStatus() != Status.NOT_FOUND.getStatusCode()) {
-                log.error("[{}] Failed to create partitioned topic {}", clientAppId(), namespaceName, e);
-                resumeAsyncResponseExceptionally(asyncResponse, e);
-                return;
-            }
+            log.error("[{}] Failed to create partitioned topic {}", clientAppId(), namespaceName, e);

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org