[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush

["absolute8511 (via GitHub)" <gi...@apache.org>]

absolute8511 commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1204187512


##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
         return isEnableBatchPush;
     }
 
-    public void setEnableBatchPush(boolean enableBatchPush) {
+    public void setIsEnableBatchPush(boolean enableBatchPush) {
         isEnableBatchPush = enableBatchPush;

Review Comment:
   If change the var name I think it will break the compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org