You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2023/01/16 10:02:51 UTC

[GitHub] [tez] abstractdog commented on a diff in pull request #262: measured input stream

abstractdog commented on code in PR #262:
URL: https://github.com/apache/tez/pull/262#discussion_r1071047228


##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/Fetcher.java:
##########
@@ -563,7 +564,7 @@ private HostFetchResult setupConnection(Collection<InputAttemptIdentifier> attem
 
   protected void setupConnectionInternal(String host, Collection<InputAttemptIdentifier> attempts)
       throws IOException, InterruptedException {
-    input = httpConnection.getInputStream();
+    input = new MeasuredDataInputStream(httpConnection.getInputStream());

Review Comment:
   thanks for the input @rbalamohan, yes, absolutely, this is a work-in-progress patch, I was thinking about making it configurable too...working on that
   I hope the basic idea makes sense to you, counting the time spent in InputStream.read to reflect the actual time spent with network traffic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org