[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2403: Core: Add SerializedTable and SerializedMetadataTable

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #2403:
URL: https://github.com/apache/iceberg/pull/2403#discussion_r605775334



##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestTableSerialization.java
##########
@@ -140,4 +194,21 @@ private static Table getMetaDataTable(Table table, MetadataTableType type) {
       throw new RuntimeException("Could not read object ", e);
     }
   }
+
+  private void checkTable(Table expected, Table actual, boolean completeCheck) {

Review comment:
       I would just do two checkTableFunctions rather than the boolean behavior switch but that's just me :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org