[GitHub] [nifi] rmarturano commented on a change in pull request #4079: NIFI-7192 - nifi.sh install not working on systemd servers

[GitBox <gi...@apache.org>]

rmarturano commented on a change in pull request #4079:
URL: https://github.com/apache/nifi/pull/4079#discussion_r576391664



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh
##########
@@ -245,6 +245,11 @@ SERVICEDESCRIPTOR
         ln -s "/etc/init.d/${SVC_NAME}" "/etc/rc2.d/K65${SVC_NAME}" || { echo "Could not create link /etc/rc2.d/K65${SVC_NAME}"; exit 1; }
         echo "Service ${SVC_NAME} installed"
     fi
+
+    # systemd: generate nifi.service from init.d
+    if [ "$(pidof systemd)" ]; then

Review comment:
       I believe it's important to check if systemd is currently running.
   I'd opt for changes suggested by @jfrazee, even though @exceptionfactory option could already cover most of the cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org