[GitHub] [beam] tysonjh commented on a change in pull request #15118: [BEAM-11666] flake on RecordingManagerTest

[GitBox <gi...@apache.org>]

tysonjh commented on a change in pull request #15118:
URL: https://github.com/apache/beam/pull/15118#discussion_r663143002



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager_test.py
##########
@@ -463,14 +463,13 @@ def test_clear(self):
     recording.wait_until_finish()
 
     # Assert that clearing only one recording clears that recording.
-    self.assertGreater(rm_1.describe()['size'], 0)
-    self.assertGreater(rm_2.describe()['size'], 0)
-    rm_1.clear()
-    self.assertEqual(rm_1.describe()['size'], 0)
-    self.assertGreater(rm_2.describe()['size'], 0)
-
-    rm_2.clear()
-    self.assertEqual(rm_2.describe()['size'], 0)
+    if rm_1.describe()['size'] > 0 and rm_2.describe()['size'] > 0:

Review comment:
       I don' t know this test very well, but it seems like that we expect both rm_1 and rm_2 to be greater than zero. If they're not greater than zero, that would indicate a problem, and the if condition just hides that problem.
   
   Is there an alternate fix that ensures rm_1 and rm_2 are both greater than zero?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org