You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2016/12/13 00:47:31 UTC
Re: Review Request 52639: Added test for `recovered` AgentID and
`AGENT_ADDED` after reregister.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52639/#review158935
-----------------------------------------------------------
Did an initial pass on the test. Refer to my comments around splitting this test into two. Would take a detailed look again post the split.
src/tests/api_tests.cpp (line 1465)
<https://reviews.apache.org/r/52639/#comment229774>
hmm, let's make this test limited to testing if the `recovered` field is correctly propagated in the `GetAgents` response
- When the master/agent are started up.
- Terminate the agent and restart master (1 recovered agent, 0 active agent)
- Restart the agent now (0 recovered agent, 1 active agent)
This is exactly the same split as you already.
Let's create another test in `src/tests/master_tests.cpp` that does the same for `/slaves` and the `/state` endpoint.
src/tests/api_tests.cpp (line 1467)
<https://reviews.apache.org/r/52639/#comment229775>
Can you remove the `Step xxx` prefix? None of the other tests in this file have it.
src/tests/api_tests.cpp (line 1472)
<https://reviews.apache.org/r/52639/#comment229776>
Kill this comment and the one earlier around starting a master. They are self-explanatory.
src/tests/api_tests.cpp (line 1493)
<https://reviews.apache.org/r/52639/#comment229780>
Can you do this outside of this scope as it's common to all subsequent blocks? It would then be consistent to all the other tests in this file.
- Anand Mazumdar
On Nov. 1, 2016, 5:30 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52639/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2016, 5:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
>
>
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp f87130d7554f98265ff6da39ea1d366839193e85
>
> Diff: https://reviews.apache.org/r/52639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 52639: Added test for `recovered` AgentID and
`AGENT_ADDED` after reregister.
Posted by Zhitao Li <zh...@gmail.com>.
> On Dec. 13, 2016, 12:47 a.m., Anand Mazumdar wrote:
> > src/tests/api_tests.cpp, line 1493
> > <https://reviews.apache.org/r/52639/diff/4/?file=1550804#file1550804line1493>
> >
> > Can you do this outside of this scope as it's common to all subsequent blocks? It would then be consistent to all the other tests in this file.
I think I will do this in a separate sweeping patch instead of this one.
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52639/#review158935
-----------------------------------------------------------
On Dec. 14, 2016, 4:49 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52639/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:49 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
>
>
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
> src/tests/master_tests.cpp b3b5630899082a69119d2cccb6460766d1352963
>
> Diff: https://reviews.apache.org/r/52639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>