You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by huikyole <gi...@git.apache.org> on 2014/08/11 21:17:02 UTC
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
GitHub user huikyole opened a pull request:
https://github.com/apache/climate/pull/102
CLIMATE-467 - Handling various calendar types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huikyole/climate stat_down
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit b939b5cbcb0d07976caed14ae238a5fd535f7c43
Author: Huikyo Lee <hu...@huikyole-2481551.rn.jpl.net>
Date: 2014-08-10T04:48:19Z
As the first stage to resolve CLIMATE-467, the old time decoding function has been replaced by netCDF4.num2date function.
commit 0b96e070791696d807b020b621e5dd068724a83e
Author: huikyole <hu...@jpl.nasa.gov>
Date: 2014-08-11T19:05:07Z
CLIMATE-467
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52648308
Build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52648326
Build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52648525
Build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by huikyole <gi...@git.apache.org>.
Github user huikyole closed the pull request at:
https://github.com/apache/climate/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52648253
Thanks for the PR @huikyole. I'll check it out ASAP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by huikyole <gi...@git.apache.org>.
Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-55335214
Please disregard this pull request because we squashed the previous changes all together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52650473
@huikyole, can you please squash down the CLIMATE-467 commits into fewer commits so they're grouped properly? Can you also split the CLIMATE-508 commits out into a separate pull request so we can test and review a single ticket worth of changes instead of multiple? Similarly, please make the commit messages more descriptive so someone can understand exactly why you're making the changes. A message with just "CLIMATE-467" or "CLIMATE-467 - additional debugging" doesn't help me understand what you're thinking =D
Thanks again for the hard work on this. I'll throw some more reviews at the code once you've pushed these changes. If you're unsure how to squash or cherry-pick commits feel free to ask and someone will be more than happy to help out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52648210
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-467 - Handling various calendar type...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-51826952
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---