[GitHub] [nuttx] XinStellaris commented on a diff in pull request #8052: drivers/pipe:add PIPEIOC_POLLTHRES to set POLLIN/POLLOUT threshold

[GitBox <gi...@apache.org>]

XinStellaris commented on code in PR #8052:
URL: https://github.com/apache/nuttx/pull/8052#discussion_r1065272889


##########
drivers/pipes/pipe_common.c:
##########
@@ -772,6 +796,20 @@ int pipecommon_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
         }
         break;
 
+      case PIPEIOC_POLLTHRES:
+        {
+          pipe_ndx_t threshold = (pipe_ndx_t)arg;

Review Comment:
   Okay, it will be done.
   Current code is okay for our case, but from user's view, it is better to set different threshold for input/output so that it can be used in other places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org