You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Kirill Tkalenko (Jira)" <ji...@apache.org> on 2021/11/02 13:19:00 UTC

[jira] [Comment Edited] (IGNITE-15371) [Ignite 3] Switch to Google code style

    [ https://issues.apache.org/jira/browse/IGNITE-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437355#comment-17437355 ] 

Kirill Tkalenko edited comment on IGNITE-15371 at 11/2/21, 1:18 PM:
--------------------------------------------------------------------

[~sk0x50] Please make code review.

At the moment, I made changes for all the rules except these, from (*check-rules/checkstyle-rules.xml*):
* SummaryJavadoc
* MissingJavadocMethod
* MissingJavadocType

We will make them on a separate ticket.


was (Author: ktkalenko@gridgain.com):
[~sk0x50] Please make code review.

At the moment, I made changes for all the rules except these, from (*check-rules/checkstyle-rules.xml*):
* SummaryJavadoc
* MissingJavadocMethod
* MissingJavadocType


> [Ignite 3] Switch to Google code style
> --------------------------------------
>
>                 Key: IGNITE-15371
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15371
>             Project: Ignite
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Valentin Kulichenko
>            Assignee: Kirill Tkalenko
>            Priority: Major
>              Labels: ignite-3
>         Attachments: ignite-checks.xml
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As agreed in [1], we need to switch to the Google code style with two changes:
> * 140 column limit instead of 100
> * 4/8 spaces indentation instead of 2/4
> The updated XML file for the Checkstyle Plugin is attached.
> Also, 
> # Create coding guideline wiki page for Ignite 3 
> # Update links to CONTRIBUTING.md
> [1] https://lists.apache.org/thread.html/rfa1e775f27b99b1f14c356e25cc52f83eb90c7553db1f1a2aba136c6%40%3Cdev.ignite.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)