You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/11/29 12:44:05 UTC
Review Request 64156: Log Search: backend should not return with 302
redirect if authentication fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert Nettleton.
Bugs: AMBARI-22543
https://issues.apache.org/jira/browse/AMBARI-22543
Repository: ambari
Description
-------
Without proper authentication details rest calls returs with 302 (to /login), that should be changed and get a 401 status
Diffs
-----
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java 2fe5f7b
Diff: https://reviews.apache.org/r/64156/diff/1/
Testing
-------
done
Thanks,
Oliver Szabo
Re: Review Request 64156: Log Search: backend should not return with
302 redirect if authentication fails
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192121
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 12:44 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert Nettleton.
>
>
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Without proper authentication details rest calls returs with 302 (to /login), that should be changed and get a 401 status
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java 2fe5f7b
>
>
> Diff: https://reviews.apache.org/r/64156/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 64156: Log Search: backend should not return with
302 redirect if authentication fails
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192118
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 12:44 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert Nettleton.
>
>
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Without proper authentication details rest calls returs with 302 (to /login), that should be changed and get a 401 status
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java 2fe5f7b
>
>
> Diff: https://reviews.apache.org/r/64156/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 64156: Log Search: backend should not return with
302 redirect if authentication fails
Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192117
-----------------------------------------------------------
Ship it!
Ship It!
- Krisztian Kasa
On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 12:44 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert Nettleton.
>
>
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Without proper authentication details rest calls returs with 302 (to /login), that should be changed and get a 401 status
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java 2fe5f7b
>
>
> Diff: https://reviews.apache.org/r/64156/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>