You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/11 11:55:40 UTC
[GitHub] [hudi] linfey90 opened a new pull request, #6369: optimized code in the class of HoodieFlinkStreamer
linfey90 opened a new pull request, #6369:
URL: https://github.com/apache/hudi/pull/6369
### Change Logs
Before that, the code 'FlinkStreamerConfig.toFlinkConfig(cfg)' will be called twice. It's mostly misleading and the same thing both times.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6369: optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6369:
URL: https://github.com/apache/hudi/pull/6369#issuecomment-1212639920
Thanks for the contribution @linfey90 , it is a valid fix, can you fire a JIRA issue here: https://issues.apache.org/jira/projects/HUDI/issues/HUDI-4579?filter=allopenissues
and change the commit title to the form:
`[HUDI-${JIRA_ISSUE_ID}] ${your commit message}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] linfey90 commented on pull request #6369: [HUDI-4611] optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
linfey90 commented on PR #6369:
URL: https://github.com/apache/hudi/pull/6369#issuecomment-1212671472
> Thanks for the contribution @linfey90 , it is a valid fix, can you fire a JIRA issue here: https://issues.apache.org/jira/projects/HUDI/issues/HUDI-4579?filter=allopenissues
>
> and change the commit title to the form:
>
> `[HUDI-${JIRA_ISSUE_ID}] ${your commit message}`
> Thanks for the contribution @linfey90 , it is a valid fix, can you fire a JIRA issue here: https://issues.apache.org/jira/projects/HUDI/issues/HUDI-4579?filter=allopenissues
>
> and change the commit title to the form:
>
> `[HUDI-${JIRA_ISSUE_ID}] ${your commit message}`
I did it and I'll pay attention next time，thanks！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6369: [HUDI-4611] optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6369:
URL: https://github.com/apache/hudi/pull/6369#issuecomment-1212692501
The failed test case: `ITTestHoodieFlinkCompactor.testHoodieFlinkCompactor` seems flaky, should not be affected by this patch, would merge the PR soon ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6369: optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6369:
URL: https://github.com/apache/hudi/pull/6369#issuecomment-1212044448
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "45c1b16068742b5d54c86df8cb6be2281a55af0d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10738",
"triggerID" : "45c1b16068742b5d54c86df8cb6be2281a55af0d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45c1b16068742b5d54c86df8cb6be2281a55af0d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10738)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #6369: [HUDI-4611] optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #6369:
URL: https://github.com/apache/hudi/pull/6369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6369: optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6369:
URL: https://github.com/apache/hudi/pull/6369#issuecomment-1211943297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "45c1b16068742b5d54c86df8cb6be2281a55af0d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45c1b16068742b5d54c86df8cb6be2281a55af0d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45c1b16068742b5d54c86df8cb6be2281a55af0d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6369: optimized code in the class of HoodieFlinkStreamer
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6369:
URL: https://github.com/apache/hudi/pull/6369#issuecomment-1211948682
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "45c1b16068742b5d54c86df8cb6be2281a55af0d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10738",
"triggerID" : "45c1b16068742b5d54c86df8cb6be2281a55af0d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45c1b16068742b5d54c86df8cb6be2281a55af0d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10738)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org