You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/02/06 15:09:38 UTC

[GitHub] [drill] vvysotskyi commented on a change in pull request #1970: DRILL-7504: Upgrade Parquet library to 1.11.0

vvysotskyi commented on a change in pull request #1970: DRILL-7504: Upgrade Parquet library to 1.11.0
URL: https://github.com/apache/drill/pull/1970#discussion_r375875397
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
 ##########
 @@ -280,6 +281,12 @@ public static PartitionMetadata getPartitionMetadata(SchemaPath partitionColumn,
     return columnsStatistics;
   }
 
+  private static boolean invalidateStatistics(MetadataBase.ColumnMetadata column,
 
 Review comment:
   Please rename this method to something like `hasInvalidStatistics`, since it produces the check, but doesn't invalidate statistics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services