You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/19 19:51:40 UTC
[GitHub] [spark] DavidToneian commented on issue #27625: [SPARK-30880][DOCS]
Delete Sphinx Makefile cruft
DavidToneian commented on issue #27625: [SPARK-30880][DOCS] Delete Sphinx Makefile cruft
URL: https://github.com/apache/spark/pull/27625#issuecomment-588416199
The makefile works for me on Windows. However, if one invokes `.\make.bat` without arguments, nothing happens. Given that all targets except `html` and `clean` have been removed, I find that it is more intuitive to accept `.\make.bat` (and `make` on other platforms, for that matter) to mean to build the documentation.
Should you disagree, I propose that `.\make.bat` / `make` without arguments should result in a message being printed that tells the user what targets there are.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org