You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/22 12:54:53 UTC
[GitHub] [hbase] virajjasani opened a new pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
virajjasani opened a new pull request #2438:
URL: https://github.com/apache/hbase/pull/2438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] taklwu commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494741081
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
why can't we just use `dry-run`/ no `-f` ? seems like they're doing the same thing, please correct me if I'm missing something.
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
(reworded) is this change for using `-ignore-svn-ci` with `-f` together? it does not seem like we can use it without `dry-run`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-703610590
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 1m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | |
| uname | Linux b1d5a07332d0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 23ce91819a |
| Max. process+thread count | 54 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-696703259
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 1m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | |
| uname | Linux b81e5da6d88d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8a6299bb38 |
| Max. process+thread count | 51 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-702371669
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 1m 57s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | |
| uname | Linux 0ed932272838 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3b91a15183 |
| Max. process+thread count | 54 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-702371827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r496097803
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
I tried considering it, the only issue is user will have to manually generate ssh private/public keys from docker container and copy public key over to home.apache.org 's `~/.ssh/authorized_keys` every time they use this script in order to perform password-less scp operation :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498224048
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
> i think the ssh-agent could be used to forward credentials into the docker environment, similar to how it's done with gpg-agent.
An example for ssh-forward [here](https://github.com/nardeas/ssh-agent)
This definitely sounds reasonable, but if we just ignore svn ci, user might have other options available too (maybe upload to some apache resource via `sftp` or maybe `git checkin` or manually upload via `ui` to an apache resource?), not that I can think of much other than uploading to h.a.o/p.a.o that I am aware of, however something might come up in future and then password-less scp might become stale. I believe, having artifacts available locally for committers without PMC rights might be enough for them to decide on next step?
Even if we prefer automation around RC upload, we are not sure that all committers will have `public_html` under their respective home dir in home.apache.org, hence, I was considering option to take full path in argument (e.g `do-release-docker.sh -u home.apache.org:/home/vjasani/public_html/2.3.2RC4/`), which I believe should be acceptable. Moreover, h.a.o's authorized_keys should be updated with public key (just one time activity, not a big deal).
Overall, nothing wrong with ssh-agent based approach that we can explore but I am just thinking if it is worth having an optional additional docker container for long term.
@ndimiduk what would you prefer?
> Actually, the same authentication mechanism (ssh keys) should ideally be used for interacting with svn as well. Maybe this require infra to update the svn repository somehow.
Let me explore svn auth, i don't have much context here. Thank you for bringing this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-696703679
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| +1 :green_heart: | shellcheck | 0m 4s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 2m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 9f152b1397d9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8a6299bb38 |
| Max. process+thread count | 52 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r495228088
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
Rather than ignoring svn, what if the script could accept a flag to upload to a path in the user's home directory on https://home.apache.org. The template could also be updated to point to this https url. This way, distribution of RC artifacts remains codified by the scripts, for committers with and without PMC rights.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r496097803
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
I tried considering it, the only issue is user will have to manually generate ssh private/public keys from docker container and copy public key over to home.apache.org 's `~/.ssh/authorized_keys` every time they use this script in order to perform password-less scp operation from container :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r496171914
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
Actually, the same authentication mechanism (ssh keys) should ideally be used for interacting with svn as well. Maybe this require infra to update the svn repository somehow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498328243
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
Btw if we are good with uploading to h.a.o/p.a.o, perhaps we might not need ssh-agent either. We can mount ~/.ssh directly in docker image and that should help run password-less `scp` without issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] taklwu commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494741081
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
why can't we just use `dry-run`/ no `-f` ? seems like they're doing the same thing, please correct me if I'm missing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-702381018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498224048
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
> i think the ssh-agent could be used to forward credentials into the docker environment, similar to how it's done with gpg-agent.
An example for ssh-agent [here](https://github.com/nardeas/ssh-agent)
This definitely sounds reasonable, but if we just ignore svn ci, user might have other options available too (maybe upload to some apache resource via `sftp` or maybe `git checkin` or manually upload via `ui` to an apache resource?), not that I can think of much other than uploading to h.a.o/p.a.o that I am aware of, however something might come up in future and then password-less scp might become stale. I believe, having artifacts available locally for committers without PMC rights might be enough for them to decide on next step?
Even if we prefer automation around RC upload, we are not sure that all committers will have `public_html` under their respective home dir in home.apache.org, hence, I was considering option to take full path in argument (e.g `do-release-docker.sh -u home.apache.org:/home/vjasani/public_html/2.3.2RC4/`), which I believe should be acceptable.
Overall, nothing wrong with ssh-agent based approach that we can explore but I am just thinking if it is worth having an optional additional docker container for long term.
@ndimiduk what would you prefer?
> Actually, the same authentication mechanism (ssh keys) should ideally be used for interacting with svn as well. Maybe this require infra to update the svn repository somehow.
Let me explore svn auth, i don't have much context here. Thank you for bringing this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-703611579
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 3m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | |
| uname | Linux d44f601c7574 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 23ce91819a |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494799780
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
> is this change for using -ignore-svn-ci with -f together?
That's true, `ignore-svn-ci` is only useful when used in combination with `-f`, otherwise it is sort of no-op because dry-mode anyways don't perform svn ci.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498224048
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
> i think the ssh-agent could be used to forward credentials into the docker environment, similar to how it's done with gpg-agent.
This definitely sounds reasonable, but if we just ignore svn ci, user might have other options available too (maybe upload to some apache resource via `sftp` or maybe `git checkin` or manually upload via `ui` to an apache resource?), not that I can think of much other than uploading to h.a.o/p.a.o that I am aware of, however something might come up in future and then password-less scp might become stale. I believe, having artifacts available locally for committers without PMC rights might be enough for them to decide on next step?
Even if we prefer automation around RC upload, we are not sure that all committers will have `public_html` under their respective home dir in home.apache.org, hence, I was considering option to take full path in argument (e.g `do-release-docker.sh -u home.apache.org:/home/vjasani/public_html/2.3.2RC4/`), which I believe should be acceptable. Moreover, h.a.o's authorized_keys should be updated with public key (just one time activity, not a big deal).
Overall, nothing wrong with ssh-agent based approach that we can explore but I am just thinking if it is worth having an optional additional docker container for long term.
@ndimiduk what would you prefer?
> Actually, the same authentication mechanism (ssh keys) should ideally be used for interacting with svn as well. Maybe this require infra to update the svn repository somehow.
Let me explore svn auth, i don't have much context here. Thank you for bringing this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-696704659
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 47s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 4m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | |
| uname | Linux ebcb59476128 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8a6299bb38 |
| Max. process+thread count | 46 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] taklwu commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494741081
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
(reworded) is this change for using `-ignore-svn-ci` with `-f` together? it does not seem like we can use it without `dry-run`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494799780
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
return 0
}
+function is_svn_ci_disabled {
+ [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]
Review comment:
> is this change for using -ignore-svn-ci with -f together?
That's true, `ignore-svn-ci` is only useful when used in combination with `-f`, otherwise it is sort of no-op because dry-mode anyways don't perform svn ci.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498224048
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
> i think the ssh-agent could be used to forward credentials into the docker environment, similar to how it's done with gpg-agent.
This definitely sounds reasonable, but if we just ignore svn ci, user might have other options available too (maybe upload to some apache resource via `sftp` or maybe `git checkin` or manually upload via `ui` to an apache resource?), not that I can think of much other than uploading to h.a.o/p.a.o that I am aware of, however something might come up in future and then password-less scp might become stale. I believe, having artifacts available locally for committers without PMC rights might be enough for them to decide on next step?
Even if we prefer automation around RC upload, we are not sure that all committers will have `public_html` under their respective home dir in home.apache.org, hence, I was considering option to take full path in argument (e.g `do-release-docker.sh -u home.apache.org:/home/vjasani/public_html/2.3.2RC4/`), which I believe should be acceptable.
Overall, nothing wrong with ssh-agent based approach that we can explore but I am just thinking if it is worth having an optional additional docker container for long term.
@ndimiduk what would you prefer?
> Actually, the same authentication mechanism (ssh keys) should ideally be used for interacting with svn as well. Maybe this require infra to update the svn repository somehow.
Let me explore svn auth, i don't have much context here. Thank you for bringing this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-702381403
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| +1 :green_heart: | hadolint | 0m 2s | There were no new hadolint issues. |
| -0 :warning: | shellcheck | 0m 4s | The patch generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 2m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint |
| uname | Linux f9a8518ffcc5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3b91a15183 |
| shellcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/3/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 48 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to upload RC to home.apache.org
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-703611371
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| +1 :green_heart: | hadolint | 0m 1s | There were no new hadolint issues. |
| -0 :warning: | shellcheck | 0m 3s | The patch generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 3m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2438 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint |
| uname | Linux ca7a636b88cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 23ce91819a |
| shellcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 50 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2438/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#issuecomment-696703259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r496170748
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
Hmm that could be a bigger change, but not insurmountable: rather than copy keys, i think the ssh-agent could be used to forward credentials into the docker environment, similar to how it's done with gpg-agent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498410782
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
Sorry for too much back and forth here, was giving some thoughts on what seems better and flexible option for committers, and to answer my own question, I believe as long as we know of h.a.o upload as one of the available ways for committers to upload artifacts, we should utilize it (until better options are available).
Will try mounting local .ssh to container and using password-less scp to upload RC over h.a.o. Will try to document as much as possible (as part of `-h`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r498224048
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -77,6 +77,10 @@ Options:
If none specified, runs tag, then publish-dist, and then publish-release.
'publish-snapshot' is also an allowed, less used, option.
-x debug. do less clean up. (env file, gpg forwarding on mac)
+ -i [ignore-svn-ci]
Review comment:
> i think the ssh-agent could be used to forward credentials into the docker environment, similar to how it's done with gpg-agent.
An example for ssh-forward [here](https://github.com/nardeas/ssh-agent)
This definitely sounds reasonable, but if we just ignore svn ci, user might have other options available too (maybe upload to some apache resource via `sftp` or maybe `git checkin` or manually upload via `ui` to an apache resource?), not that I can think of much other than uploading to h.a.o/p.a.o that I am aware of, however something might come up in future and then password-less scp might become stale. I believe, having artifacts available locally for committers without PMC rights might be enough for them to decide on next step?
Even if we prefer automation around RC upload, we are not sure that all committers will have `public_html` under their respective home dir in home.apache.org, hence, I was considering option to take full path in argument (e.g `do-release-docker.sh -u home.apache.org:/home/vjasani/public_html/2.3.2RC4/`), which I believe should be acceptable.
Overall, nothing wrong with ssh-agent based approach that we can explore but I am just thinking if it is worth having an optional additional docker container for long term.
@ndimiduk what would you prefer?
> Actually, the same authentication mechanism (ssh keys) should ideally be used for interacting with svn as well. Maybe this require infra to update the svn repository somehow.
Let me explore svn auth, i don't have much context here. Thank you for bringing this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org