You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/30 11:03:14 UTC

[GitHub] [superset] vivek-kandhvar opened a new issue #15976: Adding Apache Druid database entry is broken

vivek-kandhvar opened a new issue #15976:
URL: https://github.com/apache/superset/issues/15976


   A clear and concise description of what the bug is.
   
   ### Expected results
   
   Should be able to add Apache Druid database entry, when a valid and working SQLALCHEMY URI is specified.
   
   ### Actual results
   
   The UI fails to make an api request and hence doesn't add an entry for the druid database.
   However, test connection works well.
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/29149291/127643236-242fde30-1ed4-427d-980c-d4c796317dce.png)
   
   
   If applicable, add screenshots to help explain your problem.
   
   #### How to reproduce the bug
   
   1. Go to 'Data -> Databases'
   2. Click on '+Database button' and select Apache Druid from the 
   3. Scroll down to 'Supported databases dropdown' and select Apache Druid
   4. Enter a valid url of the druid database
   5. Click Connect, and nothing happens
   4. Open browser console to see error
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `1.2.0`
   - python version: `Python 3.8.2`
   - node.js version: `v12.21.0`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] vivek-kandhvar edited a comment on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
vivek-kandhvar edited a comment on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-889936905


   The issue is because of this code which was recently merged - https://github.com/apache/superset/pull/15801/files#diff-71cc773d8c82d06647d0f3627aba355398f065d15df3f96a25b4ae19bf1f79beR560
   
   A simple null check `dbToUpdate.parameters && dbToUpdate.parameters.catalog` would have helped!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] vivek-kandhvar commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
vivek-kandhvar commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-889946503


   Oh sorry, I am on master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #15976:
URL: https://github.com/apache/superset/issues/15976


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] jinghua-qa commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-916218108


   test case updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-889945278


   thanks for reporting, @vivek-kandhvar are you on master or 1.2? im confused. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-890014097


   Prioritized! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-890023504


   Working on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] vivek-kandhvar commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
vivek-kandhvar commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-889936905


   The issue is because of this code which was recently merged - https://github.com/apache/superset/pull/15801/files#diff-71cc773d8c82d06647d0f3627aba355398f065d15df3f96a25b4ae19bf1f79beR560


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #15976: [Add Database] Adding Apache Druid database entry is broken

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15976:
URL: https://github.com/apache/superset/issues/15976#issuecomment-890012583


   @betodealmeida 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org