[jira] [Commented] (ZOOKEEPER-1819) DeserializationPerfTest calls method with wrong arguments

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980888#comment-13980888 ] 

Hadoop QA commented on ZOOKEEPER-1819:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12615226/ZOOKEEPER-1819.patch
  against trunk revision 1589949.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2064//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2064//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2064//console

This message is automatically generated.

> DeserializationPerfTest calls method with wrong arguments
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-1819
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Daniel Knightly
>            Assignee: Daniel Knightly
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1819.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The DeserializationPerfTest calls
> SerializationPerfTest.createNodes to create serialized nodes to deserialize.
> However 2 of the arguments, childcount and parentCVersion are switched in the call to the above method.  This results in all tests unintentionally testing the same scenario.



--
This message was sent by Atlassian JIRA
(v6.2#6252)