You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:58:39 UTC

[GitHub] [kylin] hit-lacus commented on a diff in pull request #1994: improve performance of getInstanceFromEnv

hit-lacus commented on code in PR #1994:
URL: https://github.com/apache/kylin/pull/1994#discussion_r992109061


##########
core-common/src/main/java/org/apache/kylin/common/KylinConfig.java:
##########
@@ -65,7 +65,7 @@ public class KylinConfig extends KylinConfigBase {
     public static final String KYLIN_CONF = "KYLIN_CONF";
 
     // static cached instances
-    private static KylinConfig SYS_ENV_INSTANCE = null;
+    private static volatile KylinConfig SYS_ENV_INSTANCE = null;

Review Comment:
   Why need add `volatile` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org