[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702862#comment-16702862 ] 

ASF GitHub Bot commented on NUMBERS-76:
---------------------------------------

GitHub user stevebosman opened a pull request:

    https://github.com/apache/commons-numbers/pull/17

    NUMBERS-76 Make "Quaternion" a ValJO

    I've done the following 
    
    * changed the constructors to private and added equivalent of methods.
    * added a parse method
    * altered equals so that (like Complex) it uses Double.equals - gets round an edge case where Quaternions with the equivalence of -0 and 0 discovered while adding tests for hashCode
    * added a divide by scalar method
    * added a norm2 (square of norm) method
    * added some additional unit tests so it should now have 100% coverage
    
    I have also emailed an ICLA.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stevebosman/commons-numbers master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-numbers/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 9c6f77801265abe079b4054c3c90d55e956ee7cd
Author: Steve Bosman <st...@...>
Date:   2018-11-28T23:15:01Z

    NUMBERS-76 Make "Quaternion" a VALJO

commit 2f33d38d6ec5513ebbad44ffad237ebbc1ae9199
Author: Steve Bosman <st...@...>
Date:   2018-11-28T23:23:57Z

    NUMBERS-76 Make "Quaternion" a VALJO - correct Javadoc

----


> Make "Quaternion" a ValJO
> -------------------------
>
>                 Key: NUMBERS-76
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-76
>             Project: Commons Numbers
>          Issue Type: Sub-task
>          Components: quaternion
>            Reporter: Gilles
>            Priority: Major
>              Labels: API
>             Fix For: 1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)