You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/07/26 19:56:02 UTC

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #746: GUACAMOLE-1320: Provide chunked file upload mechanism

jmuehlner commented on code in PR #746:
URL: https://github.com/apache/guacamole-client/pull/746#discussion_r930358479


##########
guacamole/src/main/frontend/src/app/rest/services/tunnelService.js:
##########
@@ -54,6 +54,15 @@ angular.module('rest').factory('tunnelService', ['$injector',
      */
     var DOWNLOAD_CLEANUP_WAIT = 5000;
 
+    /**
+     * The maximum size a chunk may be during uploadToStream()

Review Comment:
   Minor nitpick: Block comments should end in a period.
   
   Also it would be really helpful if this specified what units this chunk size is in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org