Review Request 13916: THRIFT-2069: TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe

[Ben Craig <be...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13916/
-----------------------------------------------------------

Review request for Thrift.


Bugs: THRIFT-2069
    https://issues.apache.org/jira/browse/THRIFT-2069


Repository: Thrift


Description
-------

THRIFT-2069: TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe
Client: cpp
Patch: Ben Craig


Diffs
-----

  lib/cpp/src/thrift/transport/TPipe.h 3c1755b 
  lib/cpp/src/thrift/transport/TPipe.cpp 92e2912 
  lib/cpp/src/thrift/transport/TPipeServer.h 88a8b6b 
  lib/cpp/src/thrift/transport/TPipeServer.cpp 10fc69b 
  lib/cpp/src/thrift/windows/OverlappedSubmissionThread.h PRE-CREATION 
  lib/cpp/src/thrift/windows/OverlappedSubmissionThread.cpp PRE-CREATION 
  lib/cpp/src/thrift/windows/Sync.h PRE-CREATION 

Diff: https://reviews.apache.org/r/13916/diff/


Testing
-------

Lots... but not tests that are currently suitable for upstreaming.

Some tests validated that a read and a write can be done concurrently on a given pipe.
Some tests validated that creating and destroying pipes frequently worked.
Some made sure that I could have multiple pipes at once.
Some did a read on one thread, then let the hosting thread die, and did a read on a different thread.


Thanks,

Ben Craig