[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1522: MINIFICPP-2065 - Only accept configuration format the agent can handle

["adamdebreceni (via GitHub)" <gi...@apache.org>]

adamdebreceni commented on code in PR #1522:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1522#discussion_r1124332857


##########
extensions/http-curl/protocols/RESTSender.cpp:
##########
@@ -181,7 +184,7 @@ C2Payload RESTSender::sendPayload(const std::string& url, const Direction direct
   const auto response_body_bytes = gsl::make_span(client.getResponseBody()).as_span<const std::byte>();
   logger_->log_trace("Received response: \"%s\"", [&] {return utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});
   if (isOkay && !clientError && !serverError) {
-    if (payload.isRaw()) {
+    if (accepted_formats) {

Review Comment:
   depending on the outgoing payload's `isRaw` to process the response seems to be a workaround, so they do not really correlate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org