[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2730: ARTEMIS-2399 Fix performance degradation when there are a lot of subscribers

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #2730: ARTEMIS-2399 Fix performance degradation when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2730#discussion_r296809409
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
 ##########
 @@ -74,6 +75,8 @@
 
    private final SoftValueLongObjectHashMap<PageCache> softCache;
 
+   private final LongObjectHashMap<PageCache> indexCacheMap;
 
 Review comment:
   @clebertsuconic They have implemented a specialized `PageCache` that just hold the offset into the page file to read the data (kafka does something similar), not the full fate `PageCache` we are used to reference with Soft references, but I agree with Clebert that it has some GC costs (both due to the TreeMap and the Integer usage).
   I think this could improved by using something primitive or (even better) by storing the offset in the page file in some paged message reference instead, wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services