You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/04 00:50:22 UTC

[GitHub] [iceberg] samredai commented on a diff in pull request #4649: Flink 1.14: Implement LookupTableSource for IcebergTableSource

samredai commented on code in PR #4649:
URL: https://github.com/apache/iceberg/pull/4649#discussion_r864395153


##########
docs/flink/flink-connector.md:
##########
@@ -141,5 +147,16 @@ SELECT * FROM flink_table;
 +----+------+
 3 rows in set
 ```
+## Lookup Join

Review Comment:
   Shouldn't this be next to the Flink SQL content? I don't like that all of Flink SQL is covered in a page called "Getting Started" but I think that section should be broken into two: "SQL" and "DataStream", in which case this will go in the "SQL" section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org