You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/07/16 22:14:58 UTC

[kudu-CR] Add support for Java dist-tests on Jenkins 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10954


Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/jenkins/build-and-test.sh
1 file changed, 55 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10954

to look at the new patch set (#7).

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M build-support/run_dist_test.py
3 files changed, 72 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/7
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10954

to look at the new patch set (#6).

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
2 files changed, 70 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/6
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 18:28:43 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 21:40:22 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Reviewed-on: http://gerrit.cloudera.org:8080/10954
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M build-support/run_dist_test.py
3 files changed, 72 insertions(+), 24 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 17
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10954

to look at the new patch set (#8).

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M build-support/run_dist_test.py
3 files changed, 72 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/8
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10954

to look at the new patch set (#5).

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/jenkins/build-and-test.sh
1 file changed, 56 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/5
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10954/7/build-support/dist_test.py
File build-support/dist_test.py:

http://gerrit.cloudera.org:8080/#/c/10954/7/build-support/dist_test.py@542
PS7, Line 542:   # TODO(Grant): Add Java tests to the flaky dashboard
Nit: ghenke



-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 17:20:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 5:

Are distributed Java tests retried on failure?

If not, we probably have enough latent flakes that we won't be able to enable distributed Java testing by default just yet.


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 21:43:43 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 5:

> I am not sure we should merge this yet given we don't have flaky support for Java tests meaning they are not being retried by dist-test. I either need to support them in the flaky dashboard (best case) or tell dist-test to always retry them 3 times. 
> 
> Because Java tests to-date have been retried 3 times, they seam pretty flaky.

Rather than gate this on flaky test tracking, could we retry 3 times as you suggested so we can turn this on now?


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 04:55:59 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 6:

I updated this patch to retry all Java tests. I also rebased and included a few small fixes based on changes since the original patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 17:00:29 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10954/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/10954/4/build-support/jenkins/build-and-test.sh@394
PS4, Line 394:     # If we're running distributed Java tests, submit them asynchronously.
> Don't we still need to run a local gradle build to actually create the JARs
Gradle understands it dependencies and will build what is needed when the distTest task is called.


http://gerrit.cloudera.org:8080/#/c/10954/4/build-support/jenkins/build-and-test.sh@567
PS4, Line 567:       echo
> Nit: indentation
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 15:28:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10954

to look at the new patch set (#4).

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/jenkins/build-and-test.sh
1 file changed, 56 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10954/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/10954/4/build-support/jenkins/build-and-test.sh@394
PS4, Line 394:     # If we're running distributed Java tests, submit them asynchronously.
Don't we still need to run a local gradle build to actually create the JARs though?


http://gerrit.cloudera.org:8080/#/c/10954/4/build-support/jenkins/build-and-test.sh@567
PS4, Line 567:       echo
Nit: indentation



-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 04:54:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 5:

I am not sure we should merge this yet given we don't have flaky support for Java tests meaning they are not being retried by dist-test. I either need to support them in the flaky dashboard (best case) or tell dist-test to always retry them 3 times. 

Because Java tests to-date have been retried 3 times, they seam pretty flaky.


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 21:43:19 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 16
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 8:

It looks like there may be a few errors I need to figure out: 
http://dist-test.cloudera.org/job?job_id=jenkins-slave.1533752818.28194


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Aug 2018 19:19:39 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 )

Change subject: Add support for Java dist-tests on Jenkins
......................................................................


Patch Set 16: Verified+1 Code-Review+2

Carrying Adar's +2 through the rebases.


-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 16
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 25 Aug 2018 03:02:03 +0000
Gerrit-HasComments: No

[kudu-CR] Add support for Java dist-tests on Jenkins

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10954

to look at the new patch set (#2).

Change subject: Add support for Java dist-tests on Jenkins
......................................................................

Add support for Java dist-tests on Jenkins

Enables running the Java dist-tests on Jenkins
when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1.
It requires BUILD_GRADLE=1 because the Maven
build doesn’t support dist-tests.

Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
---
M build-support/jenkins/build-and-test.sh
1 file changed, 56 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10954
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>