[jira] [Commented] (ARTEMIS-1950) Clarify STOMP durable subscription header names

["Lionel Cons (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520018#comment-16520018 ] 

Lionel Cons commented on ARTEMIS-1950:
--------------------------------------

I do not foresee any use case with both {{durable-subscriber-name}} and {{durable-subscription-name}}.

I am simply worried when I stumble across some piece of code that does not match the documentation because I never know which one is incorrect...

> Clarify STOMP durable subscription header names
> -----------------------------------------------
>
>                 Key: ARTEMIS-1950
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1950
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Lionel Cons
>            Assignee: Justin Bertram
>            Priority: Major
>
> The STOMP documentation describes the use of {{durable-subscription-name}} and does not mention {{durable-subscriber-name}} at all.
> However, the source code ({{VersionedStompFrameHandler.java}}) contains:
> {code}
>       String durableSubscriptionName = frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIBER_NAME);
>       if (durableSubscriptionName == null) {
>          durableSubscriptionName = frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIPTION_NAME);
>       }
>       if (durableSubscriptionName == null) {
>          durableSubscriptionName = frame.getHeader(Stomp.Headers.Subscribe.ACTIVEMQ_DURABLE_SUBSCRIPTION_NAME);
>       }
> {code}
> In other words, if both {{durable-subscription-name}} and {{durable-subscriber-name}} are set, only the undocumented {{durable-subscriber-name}} is used.
> Why do we have {{durable-subscriber-name}} in the first place?
> If used, it should be documented. If not used, it should be removed.
> BTW, {{activemq.subscriptionName}} is also used in the code and not documented. But at least it does not interfere with the documented {{durable-subscription-name}} as it comes after...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)