You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Dirk Rudolph <di...@apache.org> on 2021/06/21 11:21:44 UTC
[VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Hi,
This is a vote to promote the org.apache.sling.sitemap to its own
Sling Module. This module contains everything needed to build xml
sitemaps in Sling based applications:
- a mechanism to generate xml sitemaps in the background based on Sling Jobs
- a builder-like API for consumers to create sitemaps
- a Servlet serving sitemap index, pre-generated sitemaps or on-demand
generated sitemaps
The implementation is rather "abstract" and requires consumers to
actively opt-in by
a) implementing a SitemapGenerator (compatible to the application's
content), e.g. extending the ResourceTreeSitemapGenerator
b) setting a sling:sitemapRoot = true property "somewhere" in the content
c) configuring either a schedule for background generation or
implementing the SitemapGenerator to serve the generated sitemaps
on-demand
d) configuring service user(s) and mappings
An example was implemented for the Sling CMS. [1]
1. Code Location: in sling-whiteboard / sitemap [2]
2. Proposed Github repo: sling-org-apache-sling-sitemap
3. Proposed artifact coordinates: org.apache.sling:org.apache.sling.sitemap
Please cast your votes:
[ ] +1 Approve the promotion
[ ] 0 Don't care
[ ] -1 Don't promote, because ...
Votes will be open for at least 72h.
Best,
Dirk
[1] https://github.com/apache/sling-org-apache-sling-app-cms/compare/master...Buuhuu:feature/sitemap
[2] https://github.com/apache/sling-whiteboard/tree/master/sitemap
Re: [RESULT] [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Fri, Jun 25, 2021 at 12:44 PM Dirk Rudolph <di...@apache.org> wrote:
> ..The vote has passed...
https://github.com/apache/sling-org-apache-sling-sitemap has been
created, it should be ready to go.
Note that the SonarCould setup must be done separately,
https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis
-Bertrand
Re: [RESULT] [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Dirk Rudolph <di...@apache.org>.
Thanks Betrand and thanks Radu for the missing +1.
The vote has passed with the following result :
+1 (binding): Julian Sedding, Bertrand Delacretaz, Radu Cotescu
+1 (non binding): Dirk Rudolph
Best,
Dirk
On Fri, 25 Jun 2021 at 12:13, Radu Cotescu <ra...@apache.org> wrote:
>
> +1
>
> > On 21 Jun 2021, at 13:21, Dirk Rudolph <di...@apache.org> wrote:
> >
> > Please cast your votes:
> >
> > [ ] +1 Approve the promotion
> > [ ] 0 Don't care
> > [ ] -1 Don't promote, because ...
>
Re: [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Radu Cotescu <ra...@apache.org>.
+1
> On 21 Jun 2021, at 13:21, Dirk Rudolph <di...@apache.org> wrote:
>
> Please cast your votes:
>
> [ ] +1 Approve the promotion
> [ ] 0 Don't care
> [ ] -1 Don't promote, because ...
Re: [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Dirk,
On Fri, Jun 25, 2021 at 10:39 AM Dirk Rudolph <di...@apache.org> wrote:
> ...May I ask how to proceed from here? Has anyone else an opinion on
> that, or are the 3 +1 including mine sufficient?..
From a formal point of view we need one additional +1 from a PMC
member, as I count only two of those in this thread.
Anyone?
Once we have that you can tally the vote results here and we can
proceed to create the new repository via https://selfserve.apache.org/
. That's also restricted to PMC members, I'm happy to help with that
once the vote is done.
-Bertrand
Re: [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Dirk Rudolph <di...@apache.org>.
Thank you.
I added some coverage for the org.apache.sling.sitemap.impl.console package.
Here is my +1 as well.
May I ask how to proceed from here? Has anyone else an opinion on
that, or are the 3 +1 including mine sufficient?
Best,
Dirk
On Thu, 24 Jun 2021 at 12:53, Bertrand Delacretaz
<bd...@apache.org> wrote:
>
> Hi,
>
> On Mon, Jun 21, 2021 at 1:22 PM Dirk Rudolph <di...@apache.org> wrote:
> > ...This is a vote to promote the org.apache.sling.sitemap to its own
> > Sling Module. This module contains everything needed to build xml
> > sitemaps in Sling based applications...
>
> +1, looks useful!
>
> I checked the test coverage with -P jacoco-report and the numbers are
> great, except the org.apache.sling.sitemap.impl.console package,
> that's not a blocker.
>
> -Bertrand
Re: [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Mon, Jun 21, 2021 at 1:22 PM Dirk Rudolph <di...@apache.org> wrote:
> ...This is a vote to promote the org.apache.sling.sitemap to its own
> Sling Module. This module contains everything needed to build xml
> sitemaps in Sling based applications...
+1, looks useful!
I checked the test coverage with -P jacoco-report and the numbers are
great, except the org.apache.sling.sitemap.impl.console package,
that's not a blocker.
-Bertrand
Re: [VOTE] Promote org.apache.sling.sitemap to its own Sling Module
Posted by Julian Sedding <js...@gmail.com>.
+1
Regards
Julian
On Mon, Jun 21, 2021 at 1:21 PM Dirk Rudolph <di...@apache.org> wrote:
>
> Hi,
>
> This is a vote to promote the org.apache.sling.sitemap to its own
> Sling Module. This module contains everything needed to build xml
> sitemaps in Sling based applications:
>
> - a mechanism to generate xml sitemaps in the background based on Sling Jobs
> - a builder-like API for consumers to create sitemaps
> - a Servlet serving sitemap index, pre-generated sitemaps or on-demand
> generated sitemaps
>
> The implementation is rather "abstract" and requires consumers to
> actively opt-in by
>
> a) implementing a SitemapGenerator (compatible to the application's
> content), e.g. extending the ResourceTreeSitemapGenerator
> b) setting a sling:sitemapRoot = true property "somewhere" in the content
> c) configuring either a schedule for background generation or
> implementing the SitemapGenerator to serve the generated sitemaps
> on-demand
> d) configuring service user(s) and mappings
>
> An example was implemented for the Sling CMS. [1]
>
> 1. Code Location: in sling-whiteboard / sitemap [2]
> 2. Proposed Github repo: sling-org-apache-sling-sitemap
> 3. Proposed artifact coordinates: org.apache.sling:org.apache.sling.sitemap
>
> Please cast your votes:
>
> [ ] +1 Approve the promotion
> [ ] 0 Don't care
> [ ] -1 Don't promote, because ...
>
> Votes will be open for at least 72h.
>
> Best,
>
> Dirk
>
> [1] https://github.com/apache/sling-org-apache-sling-app-cms/compare/master...Buuhuu:feature/sitemap
> [2] https://github.com/apache/sling-whiteboard/tree/master/sitemap