You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/12 08:23:19 UTC
[kudu-CR] KUDU-2994: add NO CHRONY flag
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14691
to look at the new patch set (#2).
Change subject: KUDU-2994: add NO_CHRONY flag
......................................................................
KUDU-2994: add NO_CHRONY flag
This patch addresses KUDU-2994, adding NO_CHRONY cmake/make flag.
If -DNO_CHRONY=1 is specified with cmake options, then the Kudu testing
framework does not rely on chronyc/chronyd, and no corresponding
binaries are deployed under $BUILD_DIR/bin directory. Also, the
libmini_chronyd and libmini_chronyd_test_util libraries are not built
and references to MiniChronyd are removed from ExternalMiniCluster
in that case.
The build_mini_cluster_binaries.sh script was updated to include
-DNO_CHRONY=1 option correspondingly.
I verified that the result set of tests passes using dist-test:
http://dist-test.cloudera.org/job?job_id=aserbin.1573546681.122233
Change-Id: I95495f8a2418546048e2ea28c4f44cb399f08fd3
---
M CMakeLists.txt
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M src/kudu/clock/CMakeLists.txt
M src/kudu/clock/ntp-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
8 files changed, 94 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14691/2
--
To view, visit http://gerrit.cloudera.org:8080/14691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95495f8a2418546048e2ea28c4f44cb399f08fd3
Gerrit-Change-Number: 14691
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)