You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ramkumar Aiyengar (JIRA)" <ji...@apache.org> on 2015/03/08 13:56:38 UTC
[jira] [Reopened] (SOLR-6275) Improve accuracy of QTime reporting
[ https://issues.apache.org/jira/browse/SOLR-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Aiyengar reopened SOLR-6275:
-------------------------------------
Reopening this to resolve some Jenkins failures with the MacOSX..
[~thetaphi] pointed me to http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-May/009496.html which talks about MacOSX using wall time instead (gettimeofday) -- which would certainly fail this test (and is in some sense validation of why this issue exists! :) )
We have two approaches here..
- Disable the test for {{nanoTime}} altogether
- Disable it just for MacOSX
I haven't included reverting the change as it doesn't make things any better, the test failure is on a platform which is a no-op as far as this change is concerned anyway, and there haven't been other failures..
> Improve accuracy of QTime reporting
> -----------------------------------
>
> Key: SOLR-6275
> URL: https://issues.apache.org/jira/browse/SOLR-6275
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Ramkumar Aiyengar
> Assignee: Ramkumar Aiyengar
> Priority: Minor
> Fix For: 5.1
>
> Attachments: SOLR-6275.patch
>
>
> Currently, {{QTime}} uses {{currentTimeMillis}} instead of {{nano Time}} and hence is not suitable for time measurements. Further, it is really started after all the dispatch logic in {{SolrDispatchFilter}} (same with the top level timing reported by {{debug=timing}}) which may or may not be expensive, and hence may not fully represent the time taken by the search. This is to remedy both cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org