[GitHub] [lucene] dweiss commented on a change in pull request #681: LUCENE-10322: Enable -Xlint:path and -Xlint:-exports

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #681:
URL: https://github.com/apache/lucene/pull/681#discussion_r806675876



##########
File path: gradle/java/javac.gradle
##########
@@ -52,12 +51,12 @@ allprojects {
         "-Xlint:overrides",
         // TODO: some tests seem to have bad classpaths?
         // this check seems to be a good sanity check for gradle?
-        "-Xlint:-path",
+        "-Xlint:path",
         "-Xlint:processing",
         "-Xlint:rawtypes",
         "-Xlint:removal",
         "-Xlint:requires-automatic",
-        "-Xlint:requires-transitive-automatic",
+        "-Xlint:-requires-transitive-automatic",

Review comment:
       Just disabling this check globally is not a good way to solve it - suppress on each module that does it. Also - this should be a more fine-grained discussion on which pieces of the API should be exposed and which are simply mistakes (and should be maybe hidden entirely).

##########
File path: gradle/java/javac.gradle
##########
@@ -52,12 +51,12 @@ allprojects {
         "-Xlint:overrides",
         // TODO: some tests seem to have bad classpaths?
         // this check seems to be a good sanity check for gradle?
-        "-Xlint:-path",
+        "-Xlint:path",

Review comment:
       I would take care of this one separately to see if it can be a self-contained, small patch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org