You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/01 00:13:49 UTC

[GitHub] [beam] ryanthompson591 commented on pull request #22984: Changes CoGroupByKey typehint from List to Iterable

ryanthompson591 commented on PR #22984:
URL: https://github.com/apache/beam/pull/22984#issuecomment-1233578413

   R: tvalentyn
   
   I want to talk about this before I submit. The coGroupByKey implementation specifically does make a dictionary with a [Key to list pairing](https://github.com/apache/beam/blob/cebf7388fc7a63f138f194ec0ed39e882ebfc72c/sdks/python/apache_beam/transforms/util.py#L245).
   
   However, the documentation is very explicit that [users should expect an iterable](https://github.com/apache/beam/blob/cebf7388fc7a63f138f194ec0ed39e882ebfc72c/sdks/python/apache_beam/transforms/util.py#L148).
   
   I want to double check one last time we are not making a breaking change unless we have to.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org