[GitHub] [rocketmq] yuz10 commented on a change in pull request #3280: [ISSUE #3281 ][acl] fix fail to delete topic perm list and global white address(#3128)

[GitBox <gi...@apache.org>]

yuz10 commented on a change in pull request #3280:
URL: https://github.com/apache/rocketmq/pull/3280#discussion_r706561684



##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
##########
@@ -2263,4 +2263,19 @@ public boolean resumeCheckHalfMessage(final String addr, String msgId,
                 return false;
         }
     }
+
+    private static String join(List<String> list, String splitter) {
+        if (list == null) {
+            return null;
+        }
+        StringBuilder str = new StringBuilder();
+        for (int i = 0; i < list.size(); i++) {
+            str.append(list.get(i));
+            if (i == list.size() - 1) {
+                break;
+            }
+            str.append(splitter);
+        }
+        return str.toString();
+    }

Review comment:
       Thanks for your advice, I have moved this two functions to UtilAll 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org