You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2025/09/10 13:38:43 UTC

[PR] Defer datasource creation via a factory [camel]

Croway opened a new pull request, #19141:
URL: https://github.com/apache/camel/pull/19141

   Add dataSourceFactory property to the sql, jdbc and spring-jdbc endpoints.
   
   This way user can provide a datasource factory that creates DS at runtime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Defer datasource creation via a factory [camel]

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #19141:
URL: https://github.com/apache/camel/pull/19141#discussion_r2336992642


##########
core/camel-support/src/main/java/org/apache/camel/support/sql/DataSourceFactory.java:
##########
@@ -0,0 +1,12 @@
+package org.apache.camel.support.sql;
+
+import org.apache.camel.CamelContextAware;
+import org.apache.camel.Exchange;
+
+import javax.sql.DataSource;
+
+public interface DataSourceFactory extends CamelContextAware {

Review Comment:
   It would be good to have a bit of javadoc on this one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Defer datasource creation via a factory [camel]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway merged PR #19141:
URL: https://github.com/apache/camel/pull/19141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Defer datasource creation via a factory [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19141:
URL: https://github.com/apache/camel/pull/19141#issuecomment-3275027933

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org